-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Issue is not resolved. The group label in the edit profile modal continues to be exceeding the width it is in
- Your changes also have side effect - the padding on the pill appears to have increased and not following the original one
@callmekatootie yes i increased a bit padding, i will reset to original one. and i will paste a verification screenshot for the fix now. It was visible and working in edit profile. |
@callmekatootie screenshot |
@PrakashDurlabhji The changes are incorrect. You have used word break but you were expected to only reduce the width of the pill. Please see this: #46 (comment) I am afraid that if this does not get resolved in the next 2 hours, I will have to open this for others to pickup |
@callmekatootie in 1 hour i will complete |
@callmekatootie can you please check again? I updated |
@PrakashDurlabhji I am afraid the fix is not acceptable - you have shrunk the pill size but that is not the right way to go about it - the pill size should take up the container size it is in and have a max width... shrinking the max width would not be a good solution |
@callmekatootie i can solve this but break-word is required if we want to show full text. or i need to show ellipsis? is ellipsis ok? |
Right now, ellipsis is being showed. The fix expected is that the pill should have a max width (which it does currently and it is fine) AND if the container in which the pill exists is having a shorter width, the pill should not exceed the container's width |
@callmekatootie yes understood, now you will be satisfied with my approach. updating it |
@callmekatootie will this be ok? as i cannot control child pills width also you said i cannot alter pill css,so i have to apply changes to parent div |
No, I am afraid that is not acceptable. You can alter the Pill CSS - but not by playing with it's max width property... |
#46